New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial cluster refactor #673
Conversation
refactor aggregation of one ports make aggregategenerators deprecated in favor of aggregateoneport
e94c2cc
to
6bc2a30
Compare
6bc2a30
to
c41e5ec
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 77.42% 78.47% +1.04%
==========================================
Files 27 28 +1
Lines 6699 6691 -8
Branches 1424 1398 -26
==========================================
+ Hits 5187 5251 +64
+ Misses 1208 1136 -72
Partials 304 304
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided that test with PyPSA-Eur checks out!
Is test/test_networkclustering_module.py still needed or obsolete now?
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Double-checked against pypsa-eur |
cluster
which allows accessing clustering routines from the network itself. For example,n.cluster.cluster_spatially_by_kmeans
returns a spatially clustered version of the network.efficiency
andp_max_pu
are now aggregated by the capacity weighted mean.Clustering
class no longer contains a positive and negative linemap.Checklist
doc
.environment.yaml
,environment_docs.yaml
andsetup.py
(if applicable).doc/release_notes.rst
of the upcoming release is included.