Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stand_by_cost implementation in optimization #793

Merged
merged 4 commits into from Dec 3, 2023

Conversation

cfvescovo
Copy link
Contributor

@cfvescovo cfvescovo commented Dec 2, 2023

Closes #792.

Changes proposed in this Pull Request

Uses the same approach applied when defining the other parts of the objective function (e.g. marginal cost) for stand_by_cost

Checklist

  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@cfvescovo cfvescovo force-pushed the fix-stand-by-cost-optimization branch from 6fb4159 to c5b10c7 Compare December 2, 2023 16:46
test/test_stand_by_cost.py Outdated Show resolved Hide resolved
@cfvescovo cfvescovo force-pushed the fix-stand-by-cost-optimization branch from ff10e4a to 28332c9 Compare December 3, 2023 13:16
@cfvescovo cfvescovo force-pushed the fix-stand-by-cost-optimization branch from 28332c9 to 747f0cb Compare December 3, 2023 13:23
@fneum fneum enabled auto-merge December 3, 2023 15:37
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8196a12) 78.81% compared to head (747f0cb) 78.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files          26       26           
  Lines        7081     7081           
  Branches     1556     1556           
=======================================
  Hits         5581     5581           
  Misses       1180     1180           
  Partials      320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fneum fneum disabled auto-merge December 3, 2023 16:32
@fneum fneum merged commit aa9048d into PyPSA:master Dec 3, 2023
15 of 19 checks passed
@cfvescovo cfvescovo deleted the fix-stand-by-cost-optimization branch December 3, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stand_by_cost is not implemented correctly
3 participants