Port consideration in statistics module #860
Conversation
…gument, modularize and add functions
add gross revenue test
| @@ -119,6 +129,11 @@ def get_ports(n, c): | |||
| return [col[3:] for col in n.df(c) if col.startswith("bus")] | |||
|
|
|||
|
|
|||
| def get_stacked_ports(n, c): | |||
There was a problem hiding this comment.
Why do we need this function, because currently it is not used?
| elif isinstance(groupby, str): | ||
| by = n.df(c)[groupby] | ||
| elif isinstance(groupby, dict): | ||
| # TODO: fix kwargs behavior. what is this used for again? |
There was a problem hiding this comment.
I think this was formerly used for the energy balance, where we wanted group by the index levels so we needed something like {"level":["bus", "carrier", "bus_carrier"]}
There was a problem hiding this comment.
I think we can now remove it
|
|
||
| ports = n.df(c).loc[df.index, f"bus{port}"] | ||
| port_carriers = ports.map(n.buses.carrier) | ||
| if isinstance(bus_carrier, str): |
There was a problem hiding this comment.
I think here it would be nice to have somehing like I did before, that we fist check if the string is in n.buses.carrier.unique() and if not we look if the bus_carriers contain the string
| if isinstance(bus_carrier, str): | ||
| return df[port_carriers == bus_carrier] |
There was a problem hiding this comment.
something like:
| if isinstance(bus_carrier, str): | |
| return df[port_carriers == bus_carrier] | |
| if isinstance(bus_carrier, str): | |
| if bus_carrier in n.buses.carrier.unique(): | |
| return df[port_carriers == bus_carrier] | |
| else: | |
| return df[bus_carrier in port_carriers] |
| return [n.df(c)[bus].rename("bus"), get_carrier(n, c, nice_names=nice_names)] | ||
|
|
||
|
|
||
| def get_bus_unit_and_carrier(n, c, port="", nice_names=True): |
| if kind is not None: | ||
| if kind == "input": | ||
| df = df.clip(lower=0) | ||
| elif kind == "output": |
There was a problem hiding this comment.
This is the wrong way round
| elif kind == "output": | |
| df = df.clip(upper=0) |
| df = aggregate_components( | ||
| n, | ||
| func, | ||
| if aggregate_bus: |
There was a problem hiding this comment.
maybe also add the other attributes from dispatch like groupbyto the energy_balance and add warning that with aggregate_bus=True, this attribute will be ignored
The statistics module introduces a new keyword argument
at_portto all functions. This allows considering the port of a component when calculating statistics. Depending on the function, the default ofat_portis set toTrueorFalse, for example for the dispatch all ports are considered.The statistics module now supports an optional
portargument ingroupbyfunctions. This allows to group statistics while considering the port of a component.The
statistics.revenuefunction introduces a new keyword argumentkindto optionally calculate the revenue based on theinputcommodity or theoutputcommodity of a component.Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.