Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JRC hydro database to latest and rerun powerplantmatching #123

Merged
merged 5 commits into from
May 12, 2024

Conversation

martinhjel
Copy link
Contributor

Closes # 122.

Change proposed in this Pull Request

Have updated the JRC database to point to the latest version, not version 10 which was built in 2021.

Have also run the update_powerplants.py script to update the powerplants.csv file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@FabianHofmann
Copy link
Contributor

Great, thanks @martinhjel! Did you run the full matching process when creating the powerplants.csv?

@martinhjel
Copy link
Contributor Author

martinhjel commented Jun 30, 2023

Yes, I ran the update_powerplants.py script. It was quite large changes (11,167 additions, 5,403 deletions). @FabianHofmann, maybe you could verify that you get the same changes?

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to confirm: format has not changed?

powerplantmatching/package_data/config.yaml Show resolved Hide resolved
@FabianHofmann
Copy link
Contributor

Hey @martinhjel, would it be possible for you to reset the powerplants.csv?

git checkout master `powerplants.csv`

Then I would update the powerplant separately.

@fneum fneum merged commit 4f10f93 into PyPSA:master May 12, 2024
1 check passed
@fneum
Copy link
Member

fneum commented May 12, 2024

  • fixed to particlar commit of JRC hydro database
  • updated powerplants.csv separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants