Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify: delete bus columns with incorrect entries #219

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

martacki
Copy link
Member

dead-end busses with possibly different substation_lv, substation_off and under_construction values are being aggregated, but the dead-end bus is simply removed without updating the respective attribute of the bus it is aggregated to.

since we don't need those attributes (they are non-existent after cluster_network), I suggest to drop them to avoid confusion

@fneum
Copy link
Member

fneum commented Apr 23, 2021

Possible to do. Under what circumstances would this be actually incorrect?

These attributes as well as symbol and tags are removed in cluster_network anyway (do you see where exactly? Couldn't find it on the spot. We could do this analogously in simplify_network).

If we decide to remove them already in simplify_network (the fact that you can already pre-cluster speaks in favour of this), maybe these two additional fields should also be removed.

@martacki
Copy link
Member Author

martacki commented Apr 27, 2021

Possible to do. Under what circumstances would this be actually incorrect?

This happens when assigning an univalent bus with a different value of substation_lv/under_construction/substation_off to it's adjacent neighbor. The attributes are not updated., because the aggregation is conducted differently then in cluster_network,

These attributes as well as symbol and tags are removed in cluster_network anyway (do you see where exactly? Couldn't find it on the spot. We could do this analogously in simplify_network).

If I remember correctly, this happens in pypsa in get_clustering_from_busmap or so, because the aggregation does not consider these attributes and therefore, the output does not contain them anymore. n.buses, n.lines, etc. are then overwritten with the new output (clustering.network).

If we decide to remove them already in simplify_network (the fact that you can already pre-cluster speaks in favour of this), maybe these two additional fields should also be removed.

Sure! But let me test if the code works if the simpl wildcard is used, just came to my mind that this may cause a problem.

@martacki
Copy link
Member Author

martacki commented May 25, 2021

Sure! But let me test if the code works if the simpl wildcard is used, just came to my mind that this may cause a problem.

Indeed was causing an error. Resolved and now dropping tags and symbol as well

@martacki martacki mentioned this pull request May 28, 2021
10 tasks
@fneum
Copy link
Member

fneum commented Jun 30, 2021

Can go in once tests pass.

@martacki martacki merged commit a82b3e8 into master Jul 1, 2021
@martacki martacki deleted the substation_lv_bug branch July 1, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants