Fixing metrica epts loader #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jcnunezmoreno
commented
Oct 4, 2022
jcnunezmoreno
commented
- Frame count name is load from xml file instead of use hardcoded value (Metrica EPTS loader doen't read the frameCount name from DataFormataSpecification #158)
- Including verification before indexing the sensor value to avoid crash (Metrica EPTS loader fails when sensor is defined but player channel doen't use this information #157)
koenvo
reviewed
Oct 4, 2022
| @@ -54,11 +54,11 @@ def _frame_from_row( | |||
|
|
|||
| other_data = {} | |||
| for sensor in other_sensors: | |||
| player_sensor_field_str = f"player_{player.player_id}_{sensor.channels[0].channel_id}" | |||
| player_sensor_val = None if player_sensor_field_str not in row else row[player_sensor_field_str] | |||
There was a problem hiding this comment.
player_sensor_val = row.get(player_sensor_field_str)
Thanks you so much for the quick response. I've added a test now, and fixed the if statement. :) |
|
Sorry for the delay. Thanks for the changes! Looking good to me. Can you also run code formatting? |
Done! Thanks!! |
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.