Fix inputs of kloppy.helpers.transform #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The kloppy.helpers.transform method now allows changing the orientation without having to specify the pitch dimensions or coordinate system. - The kloppy.helpers.transform method now allows that to_pitch_dimensions is specified as a PitchDimensions object - The kloppy.helpers.transform method now allows that to_coordinate_sytem is specified as a Provider string - Removes unused and duplicate code - Additional typing and typing fixes - Added tests for the changes mentioned above - Improved exception handling Closes PySport#177
|
Thanks a lot Pieter! I’ll review this PR the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kloppy.helpers.transformmethod now allows changing the orientation without having to specifyto_pitch_dimensionsorto_coordinate_system.kloppy.helpers.transformmethod now allows thatto_pitch_dimensionsis specified as aPitchDimensionsobjectkloppy.helpers.transformmethod now allows thatto_coordinate_sytemis specified as a data provider stringCloses #177