Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Opta shot result coordinates #233

Merged
merged 3 commits into from Nov 23, 2023
Merged

Add Opta shot result coordinates #233

merged 3 commits into from Nov 23, 2023

Conversation

probberechts
Copy link
Contributor

The "result_coordinates" field of ShotEvent now contains the shot's end coordinates.

@probberechts
Add Opta shot result coordinates
c8f5a95 
The "result_coordinates" field of ShotEvent now contains the shot's end coordinates.
@JanVanHaaren
Copy link
Collaborator

Thanks! Could you please run black and remove the print statement from the _get_end_coordinates function?

@probberechts
Copy link
Contributor Author

Done.

@probberechts probberechts force-pushed the feat/opta-shot-result-coordinates branch from 55dc890 to 77af28e Compare November 19, 2023 15:52
@koenvo koenvo merged commit 62d8315 into PySport:master Nov 23, 2023
19 checks passed
@koenvo koenvo added this to the 3.14 - Pi milestone Dec 29, 2023
@probberechts probberechts deleted the feat/opta-shot-result-coordinates branch January 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanVanHaaren JanVanHaaren JanVanHaaren approved these changes

Assignees

@koenvo koenvo

Labels
None yet
Projects
None yet
Milestone
3.14 - Pi
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@probberechts @JanVanHaaren @koenvo