Fix shot end coordinates for Opta deserializer #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end coordinates of blocked and saved shots were based on the projection of the shot on the goal mouth instead of the shot's actual end location. This commit uses the x and y coordinates of the location were the shots was blocked (qualifiers 146 and 147) and inversely projects the goalmouth z coordinate (qualifier 103) on the location were the shot was blocked. Fixes PySport#244
probberechts
force-pushed
the
fix/opta-shot-result-coordinates
branch
from
5b35173
to
b6b523b
Compare
|
A unit test was added ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end coordinates of blocked and saved shots were based on the projection of the shot on the goal mouth instead of the shot's actual end location.
This commit uses the x and y coordinates of the location were the shots was blocked (qualifiers 146 and 147) and inversely projects the goalmouth z coordinate (qualifier 103) on the location were the shot was blocked.
Fixes #244