Refactor StatsBomb deserializer #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Split up StatsBombDeserializer.deserialize method refactor: Group code for deserialing events per StatsBomb event type refactor: Reorganize constants for event types and outcomes in a hierarchical structure refactor: Group tests per StatsBomb event type test: Load data from open data repository to automatically catch data updates test: Add unit tests for each deserialized event type fix: An interception before a pas must always be successful. Previously, the result of the pass was used. fix: Do not throw away bad behaviour events without a card, map them to a generic event fix: Incorrect card ids. In the open data, the following IDs are used: 7/Yellow Card, 6/Second Yellow, 5/Red. This is incorrect in the documentation. fix: Add BALL_STATE flag to metadata fix: Add prefix to synthetic events to avoid duplicate event ids fix: The get_qualifier_values method returned qualfiers instead of qualifier values fix: Interceptions do not have a body part. fix: Duels do not have a bodypart. fix: The set of synthetically-generated ball out events was very incomplete. fix: StatsBomb has no Dribble.OUT outcome. The TakeOnResult.OUT result must be derived from the related duel. fix: Freeze frame coordinates should be parsed with the shot fidelity version.
|
Thank you very much, @probberechts. I will review this pull request as soon as possible. |
There was a problem hiding this comment.
Thank you for your great effort on this pull request, @probberechts!
I left a few small questions and suggestions.
JanVanHaaren
approved these changes
Dec 22, 2023
|
Great work. I really like the approach with the intermediate SB format! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started with a small bugfix, ... ended up with a complete rewrite 😬