Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the tables.netcdf3 module #68

Closed
FrancescAlted opened this issue Jun 5, 2011 · 8 comments
Closed

Remove the tables.netcdf3 module #68

FrancescAlted opened this issue Jun 5, 2011 · 8 comments
Assignees
Milestone

Comments

@FrancescAlted
Copy link
Member

The tables.netcdf3 is not actively maintained anymore, and there are other, better packages to deal with NetCDF format in Python (like http://code.google.com/p/netcdf4-python). This module should be removed in PyTables.

@scopatz
Copy link
Member

scopatz commented Jun 6, 2011

I agree with @FrancescAlted

@avalentino
Copy link
Member

Should the module just disappear or we plan a transition period in which the module is deprecated?

  • 2.3 tables.netcdf3 is deprecated
  • 2.4 removed

@scopatz
Copy link
Member

scopatz commented Jun 7, 2011

Sounds good to me.

@avalentino
Copy link
Member

In avalentino/PyTables@c6a92c76a81dff06f062 I have added a deprecation warning on top of the netcdf3 module and also added a warning in the usermanual.

I'm not sure if we should also exclude tests related to the netcdf3 module from the test suite.

@FrancescAlted
Copy link
Member Author

Yes, in order to prevent ancillary errors (netcdf3 depends on the old Numeric package), I'd remove the tests too.

@avalentino
Copy link
Member

OK, tests for netcdf3 module are now disabled in avalentino/PyTables@134e5d6e6ad56f8253ce i.e. running test_all.py no more executes test for that module.

The test code is still there (as well as the module itself) and can be run manually.

I'm assuming that we want just deprecate the module in 2.3 and remove it only in 2.4. Is it OK for you Francesc?

@FrancescAlted
Copy link
Member Author

Yes, I'm fine with this.

Francesc Alted

@ghost ghost assigned avalentino Aug 4, 2011
@avalentino
Copy link
Member

Deprecation done with f1264e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants