Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw my code spending a lot of time in the coords = [p.nrow ...] comprehension, this change should speed up the creation of the coordinates array dramatically. The monotonic check removal is because it took a long time to create the array to do the check, it seems to be fine to just skip it because the savings are lost by allocating and doing the elementwise compare.
The idea of the change is to do the iteration directly in cython to produce a coordinate array.