-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pythainlp.util.thai_time #303
Conversation
Hello @wannaphongcom! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-10-17 07:56:16 UTC |
I convert the original class version to a version with normal function. ผมแปลงโค้ดตั้งต้นที่เป็น class ให้เป็น function ธรรมดานะครับ |
@bact โอเคครับ ผมไม่แน่ใจว่าเราควรเพิ่มวินาทีลงไปด้วยดีไหมครับ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ขออนุญาต comment เพิ่มเติมตามนี้นะครับ
Can get datetime.date as input now.
time_string -> time_data
Will merge to dev for now. Can still change until the final release of 2.1 |
Add Thai Time to PyThaiNLP
Get time/datetime object or string of time and return time spell out in Thai words.