-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward upgrade utils #1033
Merged
Merged
forward upgrade utils #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda,
tchaton,
ethanwharris and
SeanNaren
as code owners
May 16, 2022 08:42
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 181 181
Lines 7882 7937 +55
======================================
+ Hits 7474 7526 +52
- Misses 408 411 +3 |
Borda
reviewed
May 16, 2022
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
for more information, see https://pre-commit.ci
Borda
reviewed
May 17, 2022
for more information, see https://pre-commit.ci
Borda
approved these changes
May 19, 2022
justusschock
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #984
full_state_update
property toNone
. It will still works asfull_state_update=True
(old behavior) but a warning will be given to the user that they should consider setting the flag.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃