Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code from image domain #796

Merged
merged 19 commits into from
Feb 5, 2022
Merged

Remove deprecated code from image domain #796

merged 19 commits into from
Feb 5, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 24, 2022

What does this PR do?

Fixes part of #771

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jan 24, 2022
@SkafteNicki SkafteNicki added this to the v0.8 milestone Jan 24, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add chlog with removal

@Borda Borda mentioned this pull request Jan 24, 2022
5 tasks
@SkafteNicki
Copy link
Member Author

@Borda integration test are failing due to torchmetrics.PSNR no longer being available and older lightning versions are referring to it

@Borda
Copy link
Member

Borda commented Jan 25, 2022

@Borda integration test are failing due to torchmetrics.PSNR no longer being available and older lightning versions are referring to it

so shall we keep this deprecation?

@justusschock
Copy link
Member

Personally, wouldn't keep it. If we keep it, we should keep them all, I think and extend the deprecation phase. Which Lightning Version is it?

@SkafteNicki
Copy link
Member Author

If we keep it, we would only support lightning 1.5 as that release removed metrics completely.
We could do it similar to torchvision and torch compatibility:

  • 1.3 < PL < 1.5 means TM < 0.8
  • 1.5 < PL means 0.8 <= TM

@Borda
Copy link
Member

Borda commented Jan 25, 2022

If we keep it

you mean if we remove deprecated metrics, right?

@SkafteNicki
Copy link
Member Author

If we keep it

you mean if we remove deprecated metrics, right?

Yes :]

@Borda Borda enabled auto-merge (squash) February 5, 2022 00:07
@Borda Borda disabled auto-merge February 5, 2022 00:11
@Borda Borda enabled auto-merge (squash) February 5, 2022 00:11
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #796 (7fdf634) into master (b225889) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #796   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         166    165    -1     
  Lines        6827   6776   -51     
=====================================
- Hits         6452   6427   -25     
+ Misses        375    349   -26     

@mergify mergify bot added the ready label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants