Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PR #53 so yaml tests run with pyyaml<5.1 #55

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

jsiirola
Copy link
Contributor

Fixes: N/A

Summary/Motivation:

PR #53 resolved deprecation warnings with recent PyYAML, but broke tests for PyYAML<5.1. This PR resolves those test failures so that tests run cleanly for new and old versions od PyYAML.

Changes proposed in this PR:

  • Add a compatibility layer for supporting both PyYAML 5.1.x and 3.x.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4a on fix-yaml-tests into 7223482 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4a on fix-yaml-tests into 7223482 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.245% when pulling 4cdaf4a on fix-yaml-tests into 7223482 on master.

@jsiirola jsiirola merged commit 4b81557 into master Apr 23, 2019
@jsiirola jsiirola deleted the fix-yaml-tests branch April 23, 2019 03:06
@whart222
Copy link
Contributor

The PR doesn't motivate the need for this fix. In general, we are not going to be able to support backwards compatibility in all cases for third-party libraries. So what's the motivation here? I know that this impacts Pyomo development, and I expect similar backwards compatibility issues to arise there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants