Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: pomelo #2042

Merged
merged 23 commits into from May 18, 2023
Merged

feat!: pomelo #2042

merged 23 commits into from May 18, 2023

Conversation

Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented May 3, 2023

Resources

Notes

  • Contributors: Either work on the pomelo branch or target the pomelo branch with your prs for this
  • Currently waiting for additional docs from discord dev team

@Lulalaby Lulalaby added bug Something isn't working documentation Improvements or additions to documentation priority: medium Medium Priority status: planned Planned in the future feature Implements a feature upcoming discord feature Involves a feature not yet fully released by Discord undocumented discord feature This isn't documented, might not receive support for it! API Reflection Discords API wasn't correctly reflected in the lib labels May 3, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone May 3, 2023
@JustaSqu1d JustaSqu1d added the help wanted Extra attention is needed label May 5, 2023
@BobDotCom BobDotCom changed the title fix!: pomelo feat!: pomelo May 5, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2042 (c508f35) into master (6a69f66) will decrease coverage by 0.06%.
The diff coverage is 15.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
- Coverage   33.22%   33.16%   -0.06%     
==========================================
  Files          97       97              
  Lines       19092    19115      +23     
==========================================
- Hits         6343     6340       -3     
- Misses      12749    12775      +26     
Flag Coverage Δ
macos-latest-3.10 33.15% <15.90%> (-0.06%) ⬇️
macos-latest-3.11 33.15% <15.90%> (-0.06%) ⬇️
macos-latest-3.8 33.16% <15.90%> (-0.06%) ⬇️
macos-latest-3.9 33.16% <15.90%> (-0.06%) ⬇️
ubuntu-latest-3.10 33.15% <15.90%> (-0.06%) ⬇️
ubuntu-latest-3.11 33.15% <15.90%> (-0.06%) ⬇️
ubuntu-latest-3.8 33.16% <15.90%> (-0.06%) ⬇️
ubuntu-latest-3.9 33.16% <15.90%> (-0.06%) ⬇️
windows-latest-3.10 33.15% <15.90%> (-0.06%) ⬇️
windows-latest-3.11 33.15% <15.90%> (-0.06%) ⬇️
windows-latest-3.8 33.16% <15.90%> (-0.06%) ⬇️
windows-latest-3.9 33.16% <15.90%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/enums.py 79.89% <ø> (-0.14%) ⬇️
discord/guild.py 23.83% <0.00%> (+0.05%) ⬆️
discord/team.py 46.51% <0.00%> (-4.78%) ⬇️
discord/webhook/async_.py 23.16% <ø> (ø)
discord/widget.py 39.17% <0.00%> (-1.69%) ⬇️
discord/user.py 37.68% <9.52%> (-2.98%) ⬇️
discord/member.py 32.49% <20.00%> (-0.08%) ⬇️
discord/abc.py 22.46% <100.00%> (+0.12%) ⬆️
discord/types/user.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a69f66...c508f35. Read the comment docs.

discord/member.py Outdated Show resolved Hide resolved
pre-commit-ci bot and others added 5 commits May 14, 2023 10:21
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby marked this pull request as ready for review May 17, 2023 16:47
@Lulalaby Lulalaby requested a review from a team as a code owner May 17, 2023 16:47
@Dorukyum
Copy link
Member

Testing required

@Lulalaby
Copy link
Member Author

Nelo tested it successfully already.

Need one or two more testers for that.

Currently can only be tested if the bot shares a guild with a discord staff.

@NeloBlivion
Copy link
Member

Just went and tested it on DCS for staff members and everything seemed to go well

@Dorukyum Dorukyum enabled auto-merge (squash) May 18, 2023 20:23
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both

@Dorukyum Dorukyum merged commit 5019ab2 into master May 18, 2023
48 checks passed
@Lulalaby Lulalaby deleted the pomelo branch May 18, 2023 20:28
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Please add a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib bug Something isn't working documentation Improvements or additions to documentation feature Implements a feature help wanted Extra attention is needed priority: medium Medium Priority status: planned Planned in the future undocumented discord feature This isn't documented, might not receive support for it! upcoming discord feature Involves a feature not yet fully released by Discord
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants