Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve nesting error message #2275

Merged
merged 10 commits into from
Jul 8, 2024

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Dec 3, 2023

Summary

Closes #1730.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Dec 3, 2023
@Dorukyum Dorukyum self-assigned this Dec 3, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner December 3, 2023 16:59
discord/commands/core.py Outdated Show resolved Hide resolved
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum
Copy link
Member Author

Dorukyum commented Dec 3, 2023

Apparently there's an inconsistency with putting dots at the end of error messages too.
I will update this pull request to fix that.

@Dorukyum Dorukyum marked this pull request as draft December 3, 2023 17:03
@Dorukyum Dorukyum changed the title chore: improve subgroup limit error message chore: improve error messages Dec 3, 2023
@Lulalaby
Copy link
Member

Lulalaby commented Dec 3, 2023

We might do another pr soon to look through all messages

Lulalaby
Lulalaby previously approved these changes Dec 3, 2023
@Lulalaby Lulalaby added this to the v2.6 milestone Feb 28, 2024
@Dorukyum Dorukyum removed the on hold label Mar 6, 2024
@Dorukyum Dorukyum changed the title chore: improve error messages chore: improve nesting error message Jul 6, 2024
@Dorukyum Dorukyum marked this pull request as ready for review July 6, 2024 17:11
@Dorukyum Dorukyum requested a review from Lulalaby July 6, 2024 17:14
@Dorukyum Dorukyum enabled auto-merge (squash) July 6, 2024 17:14
@Dorukyum Dorukyum merged commit 63da813 into Pycord-Development:master Jul 8, 2024
29 checks passed
Lulalaby added a commit to Dorukyum/pycord that referenced this pull request Jul 8, 2024
Dorukyum added a commit that referenced this pull request Jul 9, 2024
* chore: fix incorrect pull ID

* chore: update key features

* chore: add dot

* chore: add 2.6 header

* chore: move the 2.6 header

* chore: add complete changelog link

* fix changelog position of #2275

* Update CHANGELOG.md

---------

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve this error message
2 participants