-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve nesting error message #2275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorukyum
added
priority: low
Low Priority
status: awaiting review
Awaiting review from a maintainer
labels
Dec 3, 2023
Lulalaby
reviewed
Dec 3, 2023
Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Apparently there's an inconsistency with putting dots at the end of error messages too. |
Dorukyum
changed the title
chore: improve subgroup limit error message
chore: improve error messages
Dec 3, 2023
We might do another pr soon to look through all messages |
Lulalaby
previously approved these changes
Dec 3, 2023
Dorukyum
changed the title
chore: improve error messages
chore: improve nesting error message
Jul 6, 2024
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Lulalaby
approved these changes
Jul 8, 2024
Lulalaby
added a commit
to Dorukyum/pycord
that referenced
this pull request
Jul 8, 2024
Dorukyum
added a commit
that referenced
this pull request
Jul 9, 2024
* chore: fix incorrect pull ID * chore: update key features * chore: add dot * chore: add 2.6 header * chore: move the 2.6 header * chore: add complete changelog link * fix changelog position of #2275 * Update CHANGELOG.md --------- Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1730.
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.