Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve nesting error message #2275

Merged
merged 10 commits into from
Jul 8, 2024
Merged

chore: improve nesting error message #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d1632b
chore: improve subgroup limit error message
Dorukyum Dec 3, 2023
6846376
Changelog
Dorukyum Dec 3, 2023
81d0288
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 3, 2023
f025582
Update discord/commands/core.py
Dorukyum Dec 3, 2023
82aa668
Update core.py
Dorukyum Jul 6, 2024
f83d081
Merge branch 'master' into improve-error
Dorukyum Jul 6, 2024
82bea33
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 6, 2024
ec2af89
Update CHANGELOG.md
Dorukyum Jul 6, 2024
abb9732
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 6, 2024
832a82b
Merge branch 'master' into improve-error
Lulalaby Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2170](https://github.com/Pycord-Development/pycord/pull/2170))
- `BridgeOption` must now be used for arguments in bridge commands.
([#2252](https://github.com/Pycord-Development/pycord/pull/2252))
- Changed the error message that appears when attempting to add a subcommand group to a
subcommand group. ([#2275](https://github.com/Pycord-Development/pycord/pull/2275))

### Removed

Expand Down
3 changes: 1 addition & 2 deletions discord/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,8 +1425,7 @@ def create_subgroup(
"""

if self.parent is not None:
# TODO: Improve this error message
raise Exception("a subgroup cannot have a subgroup")
raise Exception("A subcommand group cannot be added to a subcommand group")

sub_command_group = SlashCommandGroup(
name, description, guild_ids, parent=self, **kwargs
Expand Down
Loading