Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AttributeError when failing to establish initial websocket connection #2301

Merged
merged 6 commits into from Dec 27, 2023
Merged

fix: AttributeError when failing to establish initial websocket connection #2301

merged 6 commits into from Dec 27, 2023

Conversation

Dasupergrasskakjd
Copy link
Contributor

@Dasupergrasskakjd Dasupergrasskakjd commented Dec 25, 2023 •
edited

Summary

Fixes #2300

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dasupergrasskakjd Dasupergrasskakjd requested a review from a team as a code owner December 25, 2023 17:27
@pullapprove4 pullapprove4 bot requested a review from Lulalaby December 25, 2023 17:27
@pullapprove4 pullapprove4 bot requested a review from Dorukyum December 25, 2023 17:27
@Dasupergrasskakjd Dasupergrasskakjd changed the title fix #2300 fix: #2300 Dec 25, 2023
JustaSqu1d
JustaSqu1d suggested changes Dec 25, 2023
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the PR title more informative (just modifying the change log entry for the title would be fine)

CHANGELOG.md Outdated Show resolved Hide resolved
Dorukyum
Dorukyum reviewed Dec 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JustaSqu1d JustaSqu1d added bug Something isn't working python Pull requests that update Python code labels Dec 26, 2023
JustaSqu1d
JustaSqu1d suggested changes Dec 26, 2023
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the PR title more informative

@Dasupergrasskakjd @Dorukyum
Update CHANGELOG.md
e130ff5 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: Dasupergrasskakjd <106623583+Dasupergrasskakjd@users.noreply.github.com>
@Dasupergrasskakjd Dasupergrasskakjd changed the title fix: #2300 fix: #2300 AttributeError when failing to establish initial websocket connection. Dec 26, 2023
@Lulalaby Lulalaby changed the title fix: #2300 AttributeError when failing to establish initial websocket connection. fix: AttributeError when failing to establish initial websocket connection. Dec 27, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) December 27, 2023 16:33
@Dorukyum Dorukyum changed the title fix: AttributeError when failing to establish initial websocket connection. fix: AttributeError when failing to establish initial websocket connection Dec 27, 2023
@Lulalaby Lulalaby merged commit ec212e2 into Pycord-Development:master Dec 27, 2023
33 checks passed
@Lulalaby Lulalaby removed the request for review from JustaSqu1d December 27, 2023 17:38
@Dasupergrasskakjd Dasupergrasskakjd deleted the Fix-2300 branch December 27, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d requested changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError in client.Connect in certain conditions(rare)
4 participants
@Dasupergrasskakjd @Lulalaby @Dorukyum @JustaSqu1d