Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AttributeError when failing to establish initial websocket connection #2301

Merged
merged 6 commits into from Dec 27, 2023
Merged

fix: AttributeError when failing to establish initial websocket connection #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff897cb
fix #2300
Dasupergrasskakjd Dec 25, 2023
1779749
Update CHANGELOG.md
Dasupergrasskakjd Dec 25, 2023
4d6edfb
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 25, 2023
3869a80
Update CHANGELOG.md
Dasupergrasskakjd Dec 25, 2023
e130ff5
Update CHANGELOG.md
Dasupergrasskakjd Dec 26, 2023
2d0ad16
Merge branch 'master' into Fix-2300
Dasupergrasskakjd Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -203,6 +203,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2257](https://github.com/Pycord-Development/pycord/issues/2257))
- Fixed `AuditLogIterator` not respecting the `after` parameter.
([#2295](https://github.com/Pycord-Development/pycord/issues/2295))
- Fixed `AttributeError` when failing to establish initial websocket connection.
([#2301](https://github.com/Pycord-Development/pycord/pull/2301))

## [2.4.1] - 2023-03-20

Expand Down
2 changes: 2 additions & 0 deletions discord/client.py
View file
Open in desktop
Expand Up @@ -653,6 +653,8 @@ async def connect(self, *, reconnect: bool = True) -> None:
# Always try to RESUME the connection
# If the connection is not RESUME-able then the gateway will invalidate the session.
# This is apparently what the official Discord client does.
if self.ws is None:
continue
ws_params.update(
sequence=self.ws.sequence, resume=True, session=self.ws.session_id
)
Expand Down