Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect type-hint for RawMemberRemoveEvent.user #2456

Closed
wants to merge 4 commits into from
Closed

fix: incorrect type-hint for RawMemberRemoveEvent.user #2456

wants to merge 4 commits into from

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented May 16, 2024

Summary

Fixed the type-hinting of RawMemberRemoveEvent.user to reflect actual behavior.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys requested a review from a team as a code owner May 16, 2024 23:01
@pullapprove4 pullapprove4 bot requested a review from Dorukyum May 16, 2024 23:01
yoggys and others added 2 commits May 17, 2024 01:02
@yoggys
Update CHANGELOG.md
2ed82bd 
Signed-off-by: YoggieS <61660055+yoggys@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
edf37c3
plun1331
plun1331 reviewed May 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yoggys @plun1331
Update CHANGELOG.md
cdfce27 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: YoggieS <61660055+yoggys@users.noreply.github.com>
@yoggys yoggys requested a review from plun1331 May 17, 2024 07:44
@plun1331 plun1331 changed the title fix: RawMemberRemoveEvent type-hinting fix: incorrect type-hint for RawMemberRemoveEvent.user May 17, 2024
@plun1331 plun1331 enabled auto-merge (squash) May 17, 2024 13:12
@plun1331 plun1331 added bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels May 17, 2024
@plun1331 plun1331 added this to the v2.6 milestone May 17, 2024
@yoggys yoggys mentioned this pull request May 17, 2024
Merged
9 tasks
@plun1331
Copy link
Member

Superseded by #2457

@plun1331 plun1331 closed this May 18, 2024
auto-merge was automatically disabled May 18, 2024 04:06

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoggys @plun1331