Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext.pages updates/changes #629

Merged
merged 48 commits into from
Jan 7, 2022
Merged

ext.pages updates/changes #629

merged 48 commits into from
Jan 7, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Dec 23, 2021

Summary

Provides the following enhancements/feature requests to ext.pages:

  • Rework of how buttons are added/removed to allow for greater flexibility
  • Option to loop the paginator when reaching the end
  • Ability to include multiple embeds in a single page
  • Option to switch between groups of pages with a select menu
  • Option to send the paginated message to a different target than the context where it was invoked from
  • Rework send() and respond() to be more consistent with other library usages of those methods
  • More usage examples

Note: This PR is a breaking change for the existing ext.pages module as it completely reworks a large portion of how buttons are handled.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

krittick and others added 28 commits December 26, 2021 23:30
sorry in advance
Replace First Argument of Paginator.send to be only Context
…responding menu for switching page groups (not working yet)
@krittick krittick marked this pull request as ready for review January 2, 2022 08:49
@Lulalaby Lulalaby enabled auto-merge (squash) January 2, 2022 14:09
@Lulalaby Lulalaby added documentation Improvements or additions to documentation feature Implements a feature Merge with rebase priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Jan 2, 2022
@Lulalaby Lulalaby added this to In progress in v2.0 via automation Jan 2, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 2, 2022
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not approving tho.
@Middledot please review

Copy link
Member

@ChickenDevs ChickenDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good here, still not fully approving yet though.

Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here

@Lulalaby Lulalaby merged commit 58492c8 into Pycord-Development:master Jan 7, 2022
v2.0 automation moved this from In progress to Done Jan 7, 2022
docs/ext/pages/index.rst Show resolved Hide resolved
examples/views/paginator.py Show resolved Hide resolved
@krittick krittick deleted the ext-pages-updates branch January 20, 2022 18:55
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants