-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext.pages updates/changes #629
ext.pages updates/changes #629
Conversation
sorry in advance
Replace First Argument of Paginator.send to be only Context
…responding menu for switching page groups (not working yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not approving tho.
@Middledot please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good here, still not fully approving yet though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good here
Summary
Provides the following enhancements/feature requests to ext.pages:
Note: This PR is a breaking change for the existing
ext.pages
module as it completely reworks a large portion of how buttons are handled.Checklist
type: ignore
comments were used, a comment is also left explaining why