Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace First Argument of Paginator.send to be only Context #654

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

Makiyu-py
Copy link
Contributor

Summary

Fixed clear-up on Paginator.send's first parameter. (see #651)

I feel like I made an error on the documentation so please double-check thanks

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also add an option to pass a channel and a user that can use the paginator

discord/ext/pages/pagination.py Outdated Show resolved Hide resolved
@krittick
Copy link
Contributor

krittick commented Dec 27, 2021

FYI, ext.pages is currently being reworked in #629 and large changes to how send() and respond() work are being included as part of that. I can keep this change in mind when I do that, but otherwise it's going to be work that will be overwritten with the changes in #629.

@Dorukyum Dorukyum merged commit 04ec5bf into Pycord-Development:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants