Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permissions support to context menu commands #631

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Add permissions support to context menu commands #631

merged 2 commits into from
Dec 30, 2021

Conversation

krittick
Copy link
Contributor

Summary

Remake of #622 because I broke things in my fork.

Adds permissions (i.e. graying out commands based on user/role) for context menu commands (both user and message)

Implementation works exactly as it currently does for slash commands.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Lulalaby
Lulalaby previously approved these changes Dec 24, 2021
View reviewed changes
@Lulalaby Lulalaby added this to In progress in v2.0 via automation Dec 24, 2021
@Lulalaby Lulalaby added the priority: high High Priority label Dec 24, 2021
@krittick @Dorukyum
Update discord/commands/commands.py
40b228c 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby merged commit 31cd41d into Pycord-Development:master Dec 30, 2021
v2.0 automation moved this from In progress to Done Dec 30, 2021
@krittick krittick mentioned this pull request Dec 31, 2021
Merged
7 tasks
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@krittick @Dorukyum @VincentRPS
Add permissions support to context menu commands (Pycord-Development#631
de3087b 
)

* add permissions support to ContextMenuCommand

* Update discord/commands/commands.py

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
priority: high High Priority
Projects
No open projects
v2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krittick @Lulalaby @Dorukyum