Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Permission->CommandPermission rename for ContextMenuCommand #672

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Fix Permission->CommandPermission rename for ContextMenuCommand #672

merged 2 commits into from
Dec 31, 2021

Conversation

krittick
Copy link
Contributor

Summary

This adds the changes from #662 into the changes made in #631 by updating Permission to CommandPermission in the ContextMenuCommand class.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (squash) December 31, 2021 02:14
@Lulalaby Lulalaby merged commit 6927707 into Pycord-Development:master Dec 31, 2021
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@krittick @VincentRPS
Fix Permission->CommandPermission rename for ContextMenuCommand (Pyco…
28684fe 
…rd-Development#672)

* fix permission rename for ContextMenuCommand

* fix docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@VincentRPS VincentRPS VincentRPS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krittick @Lulalaby @Dorukyum @VincentRPS