Separate ApplicationContext.respond() and followup() #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion |
BobDotCom
requested changes
Dec 26, 2021
There was a problem hiding this comment.
A couple suggestions aimed towards dynamically getting the class name for better maintainability, and I also renamed followup to send_followup, and followup_webhook to followup. I'll look over it and see about what @Dorukyum said about the changes though.
auto-merge was automatically disabled
December 26, 2021 18:08
Head branch was pushed to by a user without write access
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
BobDotCom
added
priority: medium
BobDotCom
reviewed
Dec 26, 2021
plskillme x_x Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Dorukyum
reviewed
Dec 26, 2021
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
BobDotCom
approved these changes
Dec 26, 2021
Lulalaby
approved these changes
Dec 26, 2021
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #438
This PR aims to separate
ApplicationContext.respond()andApplicationContext.followup()(new function) into two seperate functions. It also renamesApplicationContext.followup(attribute) toApplicationContext.followup_webhook, but I am honestly unsure how to resolve this naming conflict, so please let me know if this should be adjusted.Checklist
type: ignorecomments were used, a comment is also left explaining why