Revert behavior change to ApplicationContext.respond, make send_response and send_followup explicit in their usage #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts the change made to
ApplicationContext.respond()
in #645, but moves its behavior from that PR toApplicationContext.send_response()
instead. This creates a more consistent experience in that bothsend_response
andsend_followup
now explicitly do what their method names suggest.While
ApplicationContext.respond()
may still be worth renaming, its current naming does make sense from a language point of view in that "responding" to something can consist of a "response" or a "follow-up" - the original context remains the same in both cases.Checklist
type: ignore
comments were used, a comment is also left explaining why