Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing back to actx.author #931

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Add typing back to actx.author #931

merged 1 commit into from
Feb 5, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Feb 5, 2022

Summary

Redo of #464, which was reverted without explanation in #848

After reflection, this new PR handles it in a slightly more appropriate way instead of defining an entirely new cached_property for what's effectively an alias from author to user.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: low Low Priority status: awaiting review Awaiting review from a maintainer Merge normally labels Feb 5, 2022
@krittick krittick self-assigned this Feb 5, 2022
@Lulalaby Lulalaby enabled auto-merge (rebase) February 5, 2022 10:27
@Lulalaby Lulalaby added this to In progress in v2.0 Feb 5, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Feb 5, 2022
@Lulalaby Lulalaby merged commit 5b76c2a into Pycord-Development:master Feb 5, 2022
v2.0 automation moved this from In progress to Done Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants