fix: do some typing in commands/context.py #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentRPS
added
Merge normally
priority: low
Lulalaby
previously approved these changes
Jan 26, 2022
Dorukyum
reviewed
Jan 28, 2022
auto-merge was automatically disabled
January 28, 2022 09:57
Head branch was pushed to by a user without write access
Dorukyum
approved these changes
Jan 28, 2022
Lulalaby
approved these changes
Jan 28, 2022
|
Specifically, this PR now causes this typing error which did not occur before the change:
|
|
wtf |
|
Why are we using |
Lulalaby
pushed a commit
that referenced
this pull request
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR just fixes some typing issues that I came across. (Specifically in
commands/context.py)Checklist
type: ignorecomments were used, a comment is also left explaining why