Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017.26.06 #131

Merged
merged 11 commits into from Jun 26, 2017

Conversation

Projects
None yet
2 participants
@Ebag333
Copy link

commented Jun 26, 2017

New Features

  • Titan Doomsday Damage: Added Titan DD to the DPS pane, as well as the raw damage done to the misc column. This allows you to better see the alpha (initial volley), as well as the total raw damage for DD's that have a DoT.
  • Font Sizes: Added 13-16 as available font sizes.

Boring Technical Stuff

  • Fixed import issues when using a "skinned" ship (old system that had duplicate ships for different skins.
  • Handle relatively uncommon issue that could cause Gnosis to run indefinitely when calculating capacitor stats. Side effect is that it's also more efficient when running in general, leading to faster recalc times.
  • Revert a rename done to a parameter, as wxPython is picky about the name. Thanks Redhand.
  • Various other misc bugfixes.

Ebag333 added some commits Jun 12, 2017

Merge pull request #129 from Pyfa-fit/effect_cleanup
Enhancement: Titan DD Damage and DPS Numbers
Merge pull request #130 from Pyfa-fit/bugfix_ID_name
Bugfix: Revert ID name change
@codacy-bot

This comment has been minimized.

Copy link

commented Jun 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 9
- Added 1
           

Complexity increasing per file
==============================
- gui/builtinViewColumns/misc.py  5
         

Clones added
============
- gui/projectedView.py  2
- eos/saveddata/module.py  1
- gui/builtinViewColumns/misc.py  1
- gui/droneView.py  1
         

Clones removed
==============
+ gui/shipBrowser.py  -1
+ gui/builtinViewColumns/baseName.py  -1
         

See the complete overview on Codacy

@@ -741,14 +741,14 @@ def _Render(self):


class PFTabsContainer(wx.Panel):
def __init__(self, parent, pos=(0, 0), size=(100, 22), init_id=wx.ID_ANY, canAdd=True):
def __init__(self, parent, pos=(0, 0), size=(100, 22), id=wx.ID_ANY, canAdd=True):

This comment has been minimized.

Copy link
@codacy-bot
@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2017

Codecov Report

Merging #131 into master will decrease coverage by <.01%.
The diff coverage is 7.04%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   14.66%   14.65%   -0.01%     
==========================================
  Files        2175     2177       +2     
  Lines       35939    35963      +24     
==========================================
+ Hits         5269     5272       +3     
- Misses      30670    30691      +21

@Ebag333 Ebag333 merged commit 6aa8a74 into master Jun 26, 2017

5 of 7 checks passed

codecov/patch 7.04% of diff hit (target 14.66%)
Details
codecov/project 14.65% (-0.01%) compared to 317eaff
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.