Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selenium container opera chrome #85

Merged

Conversation

sydoluciani
Copy link
Contributor

Adding Selenium Opera and Chrome Containers and test if travis picks the right block.

@sydoluciani sydoluciani marked this pull request as draft September 3, 2020 20:28
@sydoluciani sydoluciani marked this pull request as ready for review September 5, 2020 23:50
@stevepiercy
Copy link
Member

@sydoluciani when I run functional3 tests with tox, this does not work. I get as far as:

Serving on http://localhost:8522

Followed by many errors of:

selenium.common.exceptions.WebDriverException: Message: unknown error: net::ERR_CONNECTION_REFUSED

I'm on deform/master and deformdemo/add_selenium_container_opera_chrome, after merging the other containerization PR.

I set all the environment variables as described in contributing.md for Firefox, Chrome, or Opera. No luck. Do I need to work against a specific branch in Deform? Is there something missing from this PR?

@stevepiercy
Copy link
Member

Perhaps this PR needs to be rebased on deformdemo/master?

@stevepiercy
Copy link
Member

Yeah, I think that is the issue. When I check out master for both repos, I can run functional3 in Firefox just fine.

@sydoluciani
Copy link
Contributor Author

Please try export URL=http://your_ip_address:8522 instead of export URL=http://localhost:8522 and let me know.

@stevepiercy
Copy link
Member

None of the following worked for URL:

I'm running all this locally on my iMac.

What should I expect to see? Should a web browser launch?

@stevepiercy
Copy link
Member

I had to restart Docker Desktop (docker machine on macOS). That seems to have freed up whatever was messing up networking.

The only value of URL that worked was http://10.1.10.108:8522.

It does take a while to start up. I can monitor activity in Docker Desktop. All the tests ran successfully for Firefox. I'll try the other two browsers next.

@stevepiercy
Copy link
Member

  • Chrome: FAILED (errors=2, failures=1)
  • Opera: FAILED (errors=2, failures=1)

Is that pretty much what you expected?

I need to update contributing.md accordingly with the LAN IP using ipconfig getifaddr en0.

@sydoluciani
Copy link
Contributor Author

Yes, localhost didn't work for me either, and the rest of ip addresses probably related to Docker network and not your host ip address.

We should rewrite those failed tests to make them pass accross all 3 browsers.

@sydoluciani
Copy link
Contributor Author

in contributing.md, we can mention that Firefox is the mainstream and all tests has to pass to accept pull requests, but if any one wants to contribute, they can rewrite failed tests to work accross all 3 browsers. we mentioned this end of the contributing.md about chrome. that section needs an update.

@stevepiercy
Copy link
Member

OK, I'm going to merge this PR because it accomplishes containerization.

If you pull master, you'll see that I updated contributing.md. I need to update it again for the ip address.

I will create a new issue for the failed tests.

@stevepiercy stevepiercy merged commit 3e2ed6e into Pylons:master Sep 6, 2020
@stevepiercy
Copy link
Member

I just pushed a commit to both master and 2.0-branch so that contributing.md is up-to-date. Please remember to pull from upstream before starting a new branch.

@sydoluciani sydoluciani deleted the add_selenium_container_opera_chrome branch September 6, 2020 16:45
@sydoluciani
Copy link
Contributor Author

sydoluciani commented Sep 6, 2020

@stevepiercy OK, Thanks for the reminder. I did clone and started from scratch and checked the diff to make sure it is synced on both upstream and origin. was there any discrepancy in my recent pull requests.

When I pull from upstream, I get a message :
warning: Pulling without specifying how to reconcile divergent branches is
discouraged. You can squelch this message by running one of the following
commands sometime before your next pull:

git config pull.rebase false # merge (the default strategy)
git config pull.rebase true # rebase
git config pull.ff only # fast-forward only

Which of the above do you set in your config ?
I want always upstream over ride my local repo, and then my local repo override the origin to make sure I start exact the same is current upstram master.

@stevepiercy
Copy link
Member

Merge is my default. Sometimes I will rebase when I want to include those commits when that work will effect the work I am about to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants