-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.0 is marked as Python 2 compatible but throws syntax errors #38
Comments
Ok I forgot to release the package with python_requires metadata...
@ianb maybe you could add me as an owner so I can manage the PyPI releases? Right now I cannot as only a maintainer role. |
In the short term I have released 3.0.1 with the correct metadata. That's all I can do unless I get owner on PyPI. |
## Description PasteDeploy, which is a dependency of pylons, released a new version 3.0 which includes an f-string and is therefore not Python 2 compatible (see relevant [issue](Pylons/pastedeploy#38)). This is unfortunately breaking our CI so we will pin PasteDeploy to <3.0 for our pylons tests for now. I've pinned PasteDeploy in our pylons tests and framework tests, as well as pyramid tests (which indirectly rely on PasteDeploy as well). ## Checklist - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Motivation ## Design ## Testing strategy ## Relevant issue(s) ## Testing strategy ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone.
## Description PasteDeploy, which is a dependency of pylons, released a new version 3.0 which includes an f-string and is therefore not Python 2 compatible (see relevant [issue](Pylons/pastedeploy#38)). This is unfortunately breaking our CI so we will pin PasteDeploy to <3.0 for our pylons tests for now. I've pinned PasteDeploy in our pylons tests and framework tests, as well as pyramid tests (which indirectly rely on PasteDeploy as well). ## Checklist - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Motivation ## Design ## Testing strategy ## Relevant issue(s) ## Testing strategy ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit ca1240a)
## Description PasteDeploy, which is a dependency of pylons, released a new version 3.0 which includes an f-string and is therefore not Python 2 compatible (see relevant [issue](Pylons/pastedeploy#38)). This is unfortunately breaking our CI so we will pin PasteDeploy to <3.0 for our pylons tests for now. I've pinned PasteDeploy in our pylons tests and framework tests, as well as pyramid tests (which indirectly rely on PasteDeploy as well). ## Checklist - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Motivation ## Design ## Testing strategy ## Relevant issue(s) ## Testing strategy ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit ca1240a) # Conflicts: # .github/workflows/test_frameworks.yml
It would be really helpful to change exactly version 3.0, because now Python versions that do not support f-string try to install an incompatible version of this package with them( Most of our CI builds started crashing because they try to install that exact version, because it doesn't specify the minimum Python version We have already fixed the builds, but maybe other projects have encountered this problem too |
PasteDeploy, which is a dependency of pylons, released a new version 3.0 which includes an f-string and is therefore not Python 2 compatible (see relevant [issue](Pylons/pastedeploy#38)). This is unfortunately breaking our CI so we will pin PasteDeploy to <3.0 for our pylons tests for now. I've pinned PasteDeploy in our pylons tests and framework tests, as well as pyramid tests (which indirectly rely on PasteDeploy as well). - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone.
PasteDeploy, which is a dependency of pylons, released a new version 3.0 which includes an f-string and is therefore not Python 2 compatible (see relevant [issue](Pylons/pastedeploy#38)). This is unfortunately breaking our CI so we will pin PasteDeploy to <3.0 for our pylons tests for now. I've pinned PasteDeploy in our pylons tests and framework tests, as well as pyramid tests (which indirectly rely on PasteDeploy as well). - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Similar situation here. But importing package on Python 3.6 seems work (or at least do not raise exceptions), despite in 3.0.0 release notes there is a dropped support for Python 3.6. |
@mmerickel |
Ugh. Let me check. Maintainers were supposed to have this ability since last year. |
FFS. It seems like PyPi has been using "maintainers" and "owners" interchangeably on this feature and it is owners only. I'm filing a ticket with them. |
Hey folks, a little late in the game but I did get ownership rights and I have yanked version 3.0 from PyPI. |
To be clear, 3.0.1 is fine and still available. |
Thank you so much, @mmerickel ! This has been holding back some CI systems for me! FWIW, I did start a ticket with PyPi over the inability of maintainers to yank releases. See pypi/warehouse#12643 |
Issue
Installing
pyramid==1.9.1
on a Python 2.7 environment also installsPasteDeploy-3.0
which doesn't seem to be compatible with Python 2.7.Error
Observation
The
setup.cfg
definition is missing thepython_requires
instruction.The text was updated successfully, but these errors were encountered: