keep existing loggers when invoking setup_logging

CHANGES.rst

@@ -1,3 +1,11 @@
+unreleased
+==========
+
+- Change ``setup_logging`` to invoke ``logging.config.fileConfig`` with
+  ``disable_existing_loggers=False`` to avoid disabling any loggers that were
+  imported prior to configuration of the logging system.
+  See https://github.com/Pylons/plaster_pastedeploy/pull/16
+
 0.5 (2018-03-29)
 ================
 

src/plaster_pastedeploy/__init__.py

@@ -216,7 +216,7 @@ def setup_logging(self, defaults=None):
         """
         if 'loggers' in self.get_sections():
             defaults = self._get_defaults(defaults)
-            fileConfig(self.uri.path, defaults)
+            fileConfig(self.uri.path, defaults, disable_existing_loggers=False)
 
         else:
             logging.basicConfig()

tests/test_setup_logging.py

@@ -69,6 +69,12 @@ def test_egg_uri(self):
         assert self.basicConfig.args == ()
         assert self.basicConfig.kwargs == {}
 
+    def test_it_keeps_existing_loggers(self):
+        loader = self._makeOne()
+        loader.setup_logging()
+        assert self.fileConfig.called
+        assert self.fileConfig.kwargs['disable_existing_loggers'] is False
+
 
 class DummyFileConfig(object):
     called = False