Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF build on RTD #3290

Closed
stevepiercy opened this issue May 17, 2018 · 6 comments
Closed

Fix PDF build on RTD #3290

stevepiercy opened this issue May 17, 2018 · 6 comments
Assignees
Milestone

Comments

@stevepiercy
Copy link
Member

stevepiercy commented May 17, 2018

I broke the PDF build on RTD on the master branch. It looks like they don't support xelatex yet, but they're close.

I might have to revert bits of #3288.

I like having nice tree diagrams in the HTML, but it's at the expense of a successful PDF build on RTD. The PDF builds locally.

@stevepiercy stevepiercy self-assigned this May 17, 2018
@stevepiercy stevepiercy added this to the 1.10 milestone Jul 31, 2018
@mmerickel
Copy link
Member

@stevepiercy you need to pin to an older sphinx if necessary or whatever else it takes (I'm not super clear what's going on) to get the build working again... We can't leave our docs badge set at "failing" and every html build of rtd saying failed. https://readthedocs.org/projects/pyramid/builds/

@stevepiercy
Copy link
Member Author

It requires reverting the tree diagrams to ASCII characters. It looks like the open issue on RTD has stalled. Bummer.

@stevepiercy stevepiercy removed this from the 1.10 milestone Oct 6, 2018
@stevepiercy
Copy link
Member Author

Until RTD resolves Xelatex for PDF generation, I'll turn off PDF generation for Pyramid in the RTD Advanced settings. Users can always build a PDF locally. If there is a demand for it, then someone can submit a PR to revert the tree diagrams.

I've also removed this issue from the 1.10 milestone.

@stevepiercy
Copy link
Member Author

Some progress has been made. I am now tracking readthedocs/readthedocs.org#5453

@stevepiercy stevepiercy added this to the 2.0 milestone Mar 20, 2019
@stevepiercy
Copy link
Member Author

It has been fixed per readthedocs/readthedocs.org#5503. I will backport to 1.10-branch and 1.9-branch from master, and add a changelog entry.

This was referenced Mar 22, 2019
@stevepiercy
Copy link
Member Author

Closed by #3472, #3473, #3474, and #3475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants