SQLAlchemy code samples don't close session

[luhn]

The code samples in database/sqlalchemy.html don't close the session when the request is finished.

I was running into some problems with overflows in the SQLAlchemy connection pool, and modified the code to this:

def db(self):
    def cleanup(self):
        self.db.close()
    self.add_finished_callback(cleanup)
    return self.registry.settings['sessionmaker']()

Which so far seems to be working.

[mmerickel]

You're correct. This also needs to be updated to use config.set_request_property.

[luhn]

What's config.set_request_property?

[kusut]

I made changes as @luhn suggested.

If I want to update using add_request_method, should I remove the "changing request factory" way? Changing request factory provides an easy way to close session. With add_request_method, we have to do add_finished_callback to close session separately (or just warn about unclosed session?).

Thoughts?

[mmerickel]

What am I missing? With a request factory or a request method I would have used add_finished_callback to close the session.

[mmerickel]

Closed via 4a423fa.