Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn if there are more pending jobs than idle threads #247

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@mmerickel
Copy link
Member

commented Apr 5, 2019

Fixes comments in #243 (comment).

  1. A warning will now be emitted if a bunch of tasks are submitted while there is an idle thread, before the threads pop the jobs, because we know that when they pop them there will still be too many.
  2. Greatly simplified the shutdown logic on the threads to use only stop_count and get rid of the tombstoned None task.
  3. Shutdown now uses a condition to exit every so slightly faster when all threads are complete by having each dying thread notify.
  4. Added a warning on shutdown if any tasks are canceled.

@mmerickel mmerickel force-pushed the idle-warning-redux-2 branch from 1c91040 to c1b681d Apr 5, 2019

@bertjwregeer bertjwregeer merged commit 5bd69e9 into master Apr 5, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bertjwregeer bertjwregeer deleted the idle-warning-redux-2 branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.