backport of #424 (was: deflate'd response: use RFC compliant decompression by default) #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RFC7230](https://tools.ietf.org/html/rfc7230#section-4.2.2) specifies that > The "deflate" coding is a "zlib" data format [RFC1950](https://tools.ietf.org/html/rfc1950) containing a > "deflate" compressed data stream [RFC1951](https://tools.ietf.org/html/rfc1951) that uses a combination of > the Lempel-Ziv (LZ77) compression algorithm and Huffman coding. but also > Note: Some non-conformant implementations send the "deflate" > compressed data without the zlib wrapper. Thus deflate coded data should be expected to be received within a "zlib" container, however if no container is present, the data shouldn't be rejected. This patch tries to decode that data using RFC7230 conformant decoding and falls back to unwrapped decoding only if the previous attempt didn't work.
|
Sure, thanks for the reminder. |
|
Thanks, will cut a release in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #424 onto the 1.8-branch as suggested in #425
RFC7230 specifies
that
but also
Thus deflate coded data should be expected to be received within a
"zlib" container, however if no container is present, the data shouldn't
be rejected.
This patch tries to decode that data using RFC7230 conformant decoding
and falls back to unwrapped decoding only if the previous attempt didn't
work.