Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport of #424 (was: deflate'd response: use RFC compliant decompression by default) #426

Merged
merged 2 commits into from
Feb 11, 2021
Merged

backport of #424 (was: deflate'd response: use RFC compliant decompression by default) #426

merged 2 commits into from
Feb 11, 2021

Commits on Feb 11, 2021

  1. deflate'd response: use RFC compliant decompression by default 

    [RFC7230](https://tools.ietf.org/html/rfc7230#section-4.2.2) specifies
that

>   The "deflate" coding is a "zlib" data format [RFC1950](https://tools.ietf.org/html/rfc1950) containing a
>   "deflate" compressed data stream [RFC1951](https://tools.ietf.org/html/rfc1951) that uses a combination of
>   the Lempel-Ziv (LZ77) compression algorithm and Huffman coding.

but also

>       Note: Some non-conformant implementations send the "deflate"
>       compressed data without the zlib wrapper.

Thus deflate coded data should be expected to be received within a
"zlib" container, however if no container is present, the data shouldn't
be rejected.

This patch tries to decode that data using RFC7230 conformant decoding
and falls back to unwrapped decoding only if the previous attempt didn't
work.
    @d70-t
    d70-t committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    e65eb7a View commit details
    Browse the repository at this point in the history

  2. added deflate bugfix to changelog

    @d70-t
    d70-t committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    5c675ee View commit details
    Browse the repository at this point in the history