Refactor/remove-secret-encryption-experimental #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing due to Ansible lint failures unrelated to this PR. If you'd like I can help fix those? 🙂 |
|
Hey @onedr0p - Would you be able to PR this? 🙂 |
onedr0p
reviewed
May 2, 2023
Thanks a lot for taking a look @onedr0p 🙂 - I started working on fixing the lint issues in #202 but I was awaiting feedback on some of the task names. |
onedr0p
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove secret-encryption as experimental
Summary
Fixes #200. The
secret-encryptionis no longer an experimental feature.Issue type
Additional Information
Please let me know if there is anything else I need to change. I'm not sure whether the
k3s_use_experimentalvariable inmolecule/highavailabilityetcd/converge.ymlneeds removing because of this change.