Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(tests): Resolve Ansible Lint warnings and fix Molecule tests on GitHub Actions #202

Merged
merged 27 commits into from
May 13, 2023

Conversation

dbrennand
Copy link
Contributor

@dbrennand dbrennand commented Mar 15, 2023

TITLE

Summary

Fix Ansible Lint warnings and resolve Molecule tests failing.

Molecule v5.0.0 dropped support for lint, see ansible/molecule#3802 so I created a separate CI job for running yamllint and ansible-lint.

To fix the molecule tests, I've removed the lint section and lint test scenario from each molecule.yml file. Furthermore, the Molecule tests were failing, and I suspect this was because ubuntu-latest was updated to Ubuntu 22.04 sometime ago and cgroups v2 was causing all tests to fail. I saw similar issues in dbrennand/ansible-role-caddy-docker@2d23b79 and I resolved by dropping to ubuntu-20.04 to get the tests in a working state again.

Issue type

  • Bugfix

Test instructions

N/A

Acceptance Criteria

  • GitHub Actions Molecule tests pass (WIP).

Additional Information


@dbrennand dbrennand marked this pull request as draft March 15, 2023 19:45
tasks/pre_checks.yml Outdated Show resolved Hide resolved
tasks/pre_checks.yml Outdated Show resolved Hide resolved
@dbrennand dbrennand changed the title Fix(ansible-lint): Resolve Ansible Lint warnings Fix(tests): Resolve Ansible Lint warnings and fix Molecule tests on GitHub Actions May 12, 2023
@dbrennand dbrennand requested a review from onedr0p May 12, 2023 17:34
@dbrennand
Copy link
Contributor Author

Ready for PR @onedr0p 🙂

@onedr0p onedr0p marked this pull request as ready for review May 13, 2023 10:55
@onedr0p
Copy link
Collaborator

onedr0p commented May 13, 2023

Great work here @dbrennand . Thanks!

I need to bug @xanmanning and see what is needed to cut a release.

@onedr0p onedr0p merged commit de1bd09 into PyratLabs:main May 13, 2023
10 checks passed
@dbrennand
Copy link
Contributor Author

dbrennand commented May 13, 2023

Great work here @dbrennand . Thanks!

I need to bug @xanmanning and see what is needed to cut a release.

No worries 🙂 - Glad I could help 😄

Help us @xanmanning, you're our only hope! 😆 🙂

@dbrennand dbrennand deleted the fix/ansible-lint branch May 13, 2023 13:50
@onedr0p
Copy link
Collaborator

onedr0p commented May 13, 2023

For now with we could pin our galaxy config to the hash... eg.

roles:
  - name: xanmanning.k3s
    src: https://github.com/PyratLabs/ansible-role-k3s.git
    version: de1bd094e55b4c7b796bafc83fc55e6cb157b14f

@xanmanning
Copy link
Member

xanmanning commented May 17, 2023

Great work here @dbrennand . Thanks!
I need to bug @xanmanning and see what is needed to cut a release.

No worries slightly_smiling_face - Glad I could help smile

Help us @xanmanning, you're our only hope! laughing slightly_smiling_face

Apologies, been living under a rock for a few months.

Done some releasin'

Thanks for the hard work @dbrennand and @onedr0p !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants