Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about list indentation #752

Merged
merged 3 commits into from Nov 6, 2018
Merged

Conversation

lydell
Copy link
Contributor

@lydell lydell commented Nov 6, 2018

No description provided.

@lydell lydell mentioned this pull request Nov 6, 2018
Copy link
Member

@waylan waylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have noted some suggestions below. If you make the requested changes, I'll merge your PR.

docs/index.md Outdated
@@ -91,7 +92,9 @@ are summarized below:
In the event that one would prefer different behavior,
[tab_length](reference.md#tab_length) can be set to whatever length is
desired. Be warned however, as this will affect indentation for all aspects
of the syntax (including root level code blocks).
of the syntax (including root level code blocks). Alternatively, you could
use the [mdx_truly_sane_lists](https://github.com/radude/mdx_truly_sane_lists)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I understand the spirit of this change, I'd rather not favor any one third-party extension over another. Instead, this link should point to the wiki page where we keep a list of all known third party extensions. Perhaps one of them will meet the users needs.

And that list is publicly editable, so if you see an extension is missing, feel free to add it yourself.

docs/index.md Outdated
@@ -80,7 +80,8 @@ are summarized below:
The [syntax rules](http://daringfireball.net/projects/markdown/syntax#list)
clearly state that when a list item consists of multiple paragraphs, "each
subsequent paragraph in a list item **must** be indented by either 4 spaces
or one tab" (emphasis added). However, many implementations do not enforce
or one tab" (emphasis added). However, many implementations – including the
original markdown.pl implementation itself – do not enforce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no value in adding this. Lets leave it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#125, #313, #442 and #751 mention the original implementation as a reason for Python-Markdown to also implement this, so I figured it'd be helpful to mention that we already know that markdown.pl already behaves the way it does to avoid duplicate issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People should be searching old issues before opening a new issue, in which case they would know that. I realize GitHub doesn't search closed issues by default, but we call this out in our (new) contributing guide. If people follow the guide, then this is a non-issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People don't. I know, because I didn't (until afterwards).

@waylan waylan added docs Related to the project documentation. requires-changes Awaiting updates after a review. labels Nov 6, 2018
lydell and others added 2 commits November 6, 2018 23:38
As per the guide, we should only fix the area we are working on, so we leave the rest of the document as is, but follow the guide with our change and use a reference style link with the reference at the end of the document.

Also, remove unhelpful comment.
@lydell
Copy link
Contributor Author

lydell commented Nov 6, 2018

It was worth a try! Thanks for your time! 🎉

@lydell lydell closed this Nov 6, 2018
@lydell lydell deleted the patch-1 branch November 6, 2018 22:54
@waylan waylan merged commit daf9e6d into Python-Markdown:master Nov 6, 2018
@waylan waylan added this to the Version 3.1 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to the project documentation. requires-changes Awaiting updates after a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants