feat: Add registration page #286

orronai · 2021-09-09T18:54:12Z

Added a html template of the signup page
Added a href button to the signup page from the login page
Added the form of the signup to the backend and db

- Added a html template of the signup page - Added a href button to the signup page from the login page - Added the form of the signup to the backend and db

codecov · 2021-09-09T18:56:50Z

Codecov Report

Merging #286 (871d6e4) into master (bed689c) will increase coverage by 0.81%.
The diff coverage is 97.47%.

❗ Current head 871d6e4 differs from pull request most recent head f44f1a2. Consider uploading reports for the commit f44f1a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   78.98%   79.80%   +0.81%     
==========================================
  Files          55       59       +4     
  Lines        2346     2451     +105     
==========================================
+ Hits         1853     1956     +103     
- Misses        493      495       +2

Impacted Files	Coverage Δ
lms/models/users.py	`88.88% <88.88%> (ø)`
lms/models/register.py	`94.44% <94.44%> (ø)`
lms/lmsdb/models.py	`90.78% <100.00%> (+0.34%)`	⬆️
lms/lmsweb/__init__.py	`96.55% <100.00%> (+0.25%)`	⬆️
lms/lmsweb/forms/register.py	`100.00% <100.00%> (ø)`
lms/lmsweb/tools/validators.py	`100.00% <100.00%> (ø)`
lms/lmsweb/views.py	`90.02% <100.00%> (+1.10%)`	⬆️
lms/models/errors.py	`100.00% <100.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed689c...f44f1a2. Read the comment docs.

lms/lmsweb/tools/validators.py

lms/lmsweb/views.py

lms/templates/_formhelpers.html

lms/templates/login.html

lms/lmsweb/tools/registration.py

lms/lmsweb/views.py

- Added confirmation email system - Added some tests

lgtm-com · 2021-09-10T16:48:25Z

This pull request introduces 1 alert when merging 6ad4d4d into 4e4c203 - view on LGTM.com

new alerts:

1 for Unused import

… add-signup-page

lms/lmsdb/models.py

lms/lmsweb/tools/registration.py

lms/lmsweb/views.py

lms/lmsweb/tools/registration.py

lms/lmsweb/views.py

- Added a unique salt into confirmation link for each user - Added a test

lgtm-com · 2021-09-11T16:43:12Z

This pull request introduces 1 alert when merging 2da74c3 into bed689c - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure

lgtm-com · 2021-09-11T18:58:14Z

This pull request introduces 1 alert when merging eb717f1 into bed689c - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure

yammesicka

Awesome work 🔥

Added few improvement suggestions, please take a look :)

lms/lmsweb/tools/validators.py

lms/lmsweb/views.py

yammesicka · 2021-09-11T21:48:52Z

lms/lmsweb/views.py

+
+        return redirect(url_for(
+            'login', login_message=(
+                _('המשתמש שלך אומת בהצלחה, כעת הינך יכול להתחבר למערכת'),


אתה מועבר לדף ההתחברות (הינך בד"כ נחשב כהגבהה מלאכותית)

Changed it into אתה but now the whole sentence because he is already in the login page, the user just see the mesage that his user has been successfully confirmed and he can login

lms/models/register.py

lms/templates/signup.html

- Added few _('...') instead of some english phrases - Moved out the auth logic into models/users - Added MAIL_DEFAULT_SENDER variable to the config - Changed the retrieve_salt method

tests/test_registration.py

tests/samples/config.py.example

lms/models/users.py

orronai

Changed

…ed an error message to the UnhashedPasswordError

lms/lmsweb/views.py

lms/templates/login.html

lms/lmsweb/views.py

sourcery-ai · 2021-09-14T15:24:22Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics	Before	After	Change
Complexity	1.78 ⭐	1.73 ⭐	-0.05 👍
Method Length	33.46 ⭐	33.42 ⭐	-0.04 👍
Working memory	6.42 🙂	6.39 🙂	-0.03 👍
Quality	82.35% ⭐	82.41% ⭐	0.06% 👍

Other metrics	Before	After	Change
Lines	1575	1700	125

Changed files	Quality Before	Quality After	Quality Change
lms/lmsdb/models.py	84.38% ⭐	84.56% ⭐	0.18% 👍
lms/lmsweb/init.py	56.91% 🙂	54.82% 🙂	-2.09% 👎
lms/lmsweb/views.py	74.64% 🙂	74.25% 🙂	-0.39% 👎
lms/models/errors.py	95.58% ⭐	94.91% ⭐	-0.67% 👎
tests/conftest.py	91.19% ⭐	92.02% ⭐	0.83% 👍
tests/test_flask_limiter.py	83.28% ⭐	83.58% ⭐	0.30% 👍
tests/test_login.py	88.75% ⭐	87.61% ⭐	-1.14% 👎
tests/test_users.py	88.27% ⭐	88.41% ⭐	0.14% 👍
tests/samples/config_copy.py	96.18% ⭐	96.18% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
lms/lmsweb/views.py	comment	13 🙂	202 😞	8 🙂	50.15% 🙂	Try splitting into smaller methods
lms/lmsweb/views.py	login	5 ⭐	124 😞	12 😞	57.29% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsdb/models.py	Solution._base_next_unchecked	0 ⭐	95 🙂	20 ⛔	57.42% 🙂	Extract out complex expressions
lms/lmsweb/views.py	view	7 ⭐	134 😞	10 😞	57.80% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsdb/models.py	User.notes	1 ⭐	92 🙂	18 ⛔	58.26% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

feat: Add registration page

2cf26ed

- Added a html template of the signup page - Added a href button to the signup page from the login page - Added the form of the signup to the backend and db

yammesicka reviewed Sep 9, 2021

View reviewed changes

lms/lmsweb/tools/validators.py Show resolved Hide resolved

yammesicka approved these changes Sep 9, 2021

View reviewed changes

feat: Add registration page

3913a5e

- Added confirmation email system - Added some tests

sourcery-ai bot mentioned this pull request Sep 10, 2021

feat: Add registration page (Sourcery refactored) #291

Closed

orronai added 2 commits September 10, 2021 19:24

Fixed sourcey-ai issues

d206c6a

fixed resend email confirmation

6ad4d4d

orronai added 14 commits September 11, 2021 09:18

Merge branch 'master' of https://github.com/PythonFreeCourse/lms into…

5acbda2

… add-signup-page

Added translations

6b137af

Removed unused module

3798a2d

Changed versions of requirements

1377e9a

Changed versions of requirements

93da860

Changed versions of requirements

ec52300

Changed versions of requirements

4e47d57

Changed versions of requirements

8d08863

Changed versions of requirements

366b53f

Removed versions change

1443bad

Fixed tests

1d00a27

Fixed a test

036bdf5

Fixed test and updated client fixture

b426102

Added tests for coverage

c2ffa37

orronai linked an issue Sep 11, 2021 that may be closed by this pull request

Users' registration #288

Closed

4 tasks

Merge branch 'master' into add-signup-page

a9c22c9

yammesicka requested changes Sep 11, 2021

View reviewed changes

lms/lmsweb/views.py Outdated Show resolved Hide resolved

lms/lmsweb/views.py Outdated Show resolved Hide resolved

lms/lmsweb/views.py Show resolved Hide resolved

orronai added 2 commits September 11, 2021 19:21

- Changed role name from not_confirmed into unverified

b8dff02

- Added a unique salt into confirmation link for each user - Added a test

Fixed conflict

2da74c3

sourcery-ai bot mentioned this pull request Sep 11, 2021

feat: Add registration page (Sourcery refactored) #293

Closed

orronai added 3 commits September 11, 2021 21:32

Added a test for signature expired

fda1558

Removed unnecessary condition

6ad81a2

Added role attribute

eb717f1

This was referenced Sep 11, 2021

feat: Add registration page (Sourcery refactored) #294

Closed

feat: Add registration page (Sourcery refactored) #295

Closed

yammesicka requested changes Sep 11, 2021

View reviewed changes

orronai added 3 commits September 12, 2021 11:22

- Fixed babel translations

7e87dad

- Added few _('...') instead of some english phrases - Moved out the auth logic into models/users - Added MAIL_DEFAULT_SENDER variable to the config - Changed the retrieve_salt method

Fixed a test to check bad signature token

19ecb65

Fixed a test

71fbb2f

yammesicka requested changes Sep 12, 2021

View reviewed changes

tests/test_registration.py Show resolved Hide resolved

tests/samples/config.py.example Outdated Show resolved Hide resolved

lms/models/users.py Outdated Show resolved Hide resolved

lms/models/users.py Outdated Show resolved Hide resolved

orronai commented Sep 12, 2021

View reviewed changes

orronai added 2 commits September 12, 2021 12:58

Moved out the HASHED_PASSWORD in order to be global variable, and add…

d4bd32a

…ed an error message to the UnhashedPasswordError

Added a configuration of registration open, and a test

436fc9f