Ike complete order database refactor #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwally
approved these changes
Feb 13, 2017
|
MAIN BANANAS 🍌 🍌 🍌 |
|
works amazing!!!! RUNS ALL THE TESTS 🥇 👍 it's bananas 🍌 |
|
|
||
|
|
||
|
|
||
| # except: |
There was a problem hiding this comment.
Please remove commented code before submitting a PR.
| @@ -47,6 +47,7 @@ def add_product_to_order(self, product): | |||
| AND quantity = {} | |||
| """.format(product.get_product_title(), product.get_product_description(), product.get_product_price(), product.get_product_quantity())) | |||
| selected_product = cursor.fetchone() | |||
| print(selected_product, "this is selected prod w zoe") | |||
There was a problem hiding this comment.
Remove debugging statements before submitting a PR
| selected_product = cursor.fetchone() | ||
| cursor.close() | ||
|
|
||
| rfk = Customer("Robert Kennedy", '1919 Heron Pointe Dr', "Nashville", "TN", 37214, '8888978880') |
There was a problem hiding this comment.
Some white space to break up the code into conceptual blocks, along with comments, will make this code easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete an order by tying payment type to order and setting payment complete to 1.
Number of Fixes
#6 , #9, #20,
Related Ticket(s)
#1 ,
Problem to Solve
Describe the problem(s) this pull request solves.
Tests a customer can complete an order e.g.-Allows a customer to complete an order (add payment type to an order and set order complete to 1)
Proposed Changes
Describe the proposed changes.
Expected Behavior
Describe the expected behavior.
Within the database, selected order should be 1
Steps to Test Solution
run python runtests.pyTesting
[x ] There are new unit tests in this PR, and I verify that there is full coverage of all new code.
[ x] I certify that all existing tests pass
Documentation
[ x] There is new documentation in this pull request that must be reviewed..
[ x] I added documentation for any new classes/methods
Deploy Notes
Notes regarding deployment the contained body of work. These should note any
db migrations, etc.