refactor eventsubws subscription error handling to not error on reconnect #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractUmbra
approved these changes
Mar 15, 2024
IAmTomahawkx
added a commit
that referenced
this pull request
Mar 17, 2024
…nect (#439) * refactor eventsubws subscription error handling to not error on reconnect * Why do we still support 3.7 * formatting
AbstractUmbra
pushed a commit
that referenced
this pull request
Mar 17, 2024
* refactor eventsubws subscription error handling to not error on reconnect * potential fix for bug with headers not getting set after token updates * Revert "refactor eventsubws subscription error handling to not error on reconnect" This reverts commit bdb21b0. * formatting * changelog entry for both prs * add more changelogs * refactor eventsubws subscription error handling to not error on reconnect (#439) * refactor eventsubws subscription error handling to not error on reconnect * Why do we still support 3.7 * formatting * Add new API routes (#441) * Add new API routes * add docs * Add user emote endpoint * work around bad frame disconnect * run black
AbstractUmbra
pushed a commit
that referenced
this pull request
Mar 24, 2024
* refactor eventsubws subscription error handling to not error on reconnect * potential fix for bug with headers not getting set after token updates * Revert "refactor eventsubws subscription error handling to not error on reconnect" This reverts commit bdb21b0. * formatting * changelog entry for both prs * add more changelogs * refactor eventsubws subscription error handling to not error on reconnect (#439) * refactor eventsubws subscription error handling to not error on reconnect * Why do we still support 3.7 * formatting * Add new API routes (#441) * Add new API routes * add docs * Add user emote endpoint * work around bad frame disconnect * run black * actually restart on bad frame * Update changelog.rst
IAmTomahawkx
added a commit
that referenced
this pull request
Mar 24, 2024
) * refactor eventsubws subscription error handling to not error on reconnect * potential fix for bug with headers not getting set after token updates * Revert "refactor eventsubws subscription error handling to not error on reconnect" This reverts commit bdb21b0. * formatting * changelog entry for both prs * add more changelogs * refactor eventsubws subscription error handling to not error on reconnect (#439) * refactor eventsubws subscription error handling to not error on reconnect * Why do we still support 3.7 * formatting * Add new API routes (#441) * Add new API routes * add docs * Add user emote endpoint * work around bad frame disconnect * run black * Fix dictionary keys used in PartialUser.fetch_moderated_channels() - use "broadcaster_" prefix to match the data returned by the API * actually restart on bad frame * Update changelog.rst * * change "broadcaster_name" to "broadcaster_login" in PartialUser.fetch_moderated_channels * update changelog * commit suggestions * commit suggestions * Apply suggestions from code review --------- Co-authored-by: IAmTomahawkx <iamtomahawkx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash where an optional Future can become
None.Checklist