Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dictionary keys used in PartialUser.fetch_moderated_channels() #443

Merged

Conversation

styles784
Copy link
Contributor

@styles784 styles784 commented Mar 19, 2024

Description

PartialUser.fetch_moderated_channels used the wrong dictionary keys to retrieve names/ids of channels the user moderates. This pull request corrects the keys from "user_" prefix to "broadcaster_" prefix in order to match the data returned by the underlying API call

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

IAmTomahawkx and others added 19 commits January 15, 2024 15:48
…nect (PythonistaGuild#439)

* refactor eventsubws subscription error handling to not error on reconnect

* Why do we still support 3.7

* formatting
* Add new API routes

* add docs
 - use "broadcaster_" prefix to match the data returned by the API
docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
@IAmTomahawkx IAmTomahawkx merged commit 8a2a839 into PythonistaGuild:master Mar 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants