Skip to content

Commit

Permalink
v1 final after having to do a resubmit. Updated readme and corrected
Browse files Browse the repository at this point in the history
app strings
  • Loading branch information
Q115 committed Aug 31, 2017
1 parent 7b372b3 commit 73d194a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions README.md
Expand Up @@ -2,7 +2,7 @@
<img src="./app/src/main/res/mipmap-xxhdpi/ic_launcher.png?raw=true" alt="Goalie">

<a href="https://play.google.com/store/apps/details?id=com.github.q115.goalie_android"><img src="https://coverse.co/webimages/download_android.svg" alt="Goalie"></a></div>
Get support from friends to reach your goals. Create a goal, and then assign a friend be your referee. The referee will help keep you accountable, and they can also help you along the way by sending you reminders. For extra incentive to reach your goals, try wagering your reputation points on the outcome.
Get support from friends to reach your goals. Create a goal, and then assign a friend be your referee. The referee will keep you accountable, and they can also help you along the way by sending you reminders. For extra incentive to reach your goals, try wagering your reputation points on the outcome.


## How to contribute
Expand All @@ -14,11 +14,11 @@ To contribute with a fix, patch, new feature, or other improvements, simply crea

## Code style and structure

Follow good programming practices and please maintain as much consistency with the rest of the project. Utilize good MVP architecture for all Activities and core Fragments (Dialogs are not held to this standard at this time).
Follow good programming practices and please maintain as much consistency with the rest of the project. Utilize MVP architecture for all Activities and core Fragments (Dialogs are not held to this standard at this time).

## Backend server

Backend server code is not open source at this time, so unit test will fail if you have don't a local server setup (will fix this problem soon). Once you submit a pull request, I'll run the test suites against my local server to make sure things are OK. If you have a feature you like to add that requires server integration, please mock the REST calls and the results you wish to get back, I'll implement the logic on the server once you make a pull request.
Backend server code is not open source at this time, so unit test will fail if you don't have a local server setup (will fix this problem soon). Once you submit a pull request, I'll run the test suites against my local server to make sure things are OK. If you have a feature you'd like to add that requires server integration, please mock the REST calls and the results that you wish to get back, I'll implement the logic on the server once you make a pull request.

## License

Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle
Expand Up @@ -7,7 +7,7 @@ android {
applicationId "com.github.q115.goalie_android"
minSdkVersion 19
targetSdkVersion 26
versionCode 3
versionCode 4
versionName "1.0"
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
Expand Up @@ -118,7 +118,7 @@
<string name="error_goal_no_title">No title entered for this goal.</string>
<string name="error_goal_invalid_date">Invalid start or end time for this goal.</string>
<string name="error_goal_no_referee">No referee set for this goal.</string>
<string name="wager_invalid">Wager amount is invalid. If you need more reputation points, you will gain 50 points when you become someone\'s referee.</string>
<string name="wager_invalid">Wager amount is invalid. If you need more reputation points, you can get them when you become someone\'s referee.</string>

<!-- Notification -->
<string name="notification_title">Goalie Notification</string>
Expand Down

0 comments on commit 73d194a

Please sign in to comment.