feat: validate database parameters (apache#14883)

superset/databases/schemas.py

@@ -276,7 +276,9 @@ def build_sqlalchemy_uri(
                 )
             engine_spec = engine_specs[engine]
 
-            if not hasattr(engine_spec, "build_sqlalchemy_uri"):
+            if not hasattr(engine_spec, "build_sqlalchemy_uri") or not hasattr(
+                engine_spec, "parameters_schema"
+            ):
                 raise ValidationError(
                     [
                         _(
@@ -286,6 +288,9 @@ def build_sqlalchemy_uri(
                     ]
                 )
 
+            # validate parameters
+            parameters = engine_spec.parameters_schema.load(parameters)  # type: ignore
+
             serialized_encrypted_extra = data.get("encrypted_extra", "{}")
             try:
                 encrypted_extra = json.loads(serialized_encrypted_extra)

tests/databases/schema_tests.py

@@ -130,3 +130,24 @@ def test_database_parameters_schema_no_mixin(get_engine_specs):
                 )
             ]
         }
+
+
+@mock.patch("superset.databases.schemas.get_engine_specs")
+def test_database_parameters_schema_mixin_invalid_type(get_engine_specs):
+    get_engine_specs.return_value = {"dummy_engine": DummyEngine}
+    payload = {
+        "engine": "dummy_engine",
+        "configuration_method": ConfigurationMethod.DYNAMIC_FORM,
+        "parameters": {
+            "username": "username",
+            "password": "password",
+            "host": "localhost",
+            "port": "badport",
+            "database": "dbname",
+        },
+    }
+    schema = DummySchema()
+    try:
+        schema.load(payload)
+    except ValidationError as err:
+        assert err.messages == {"port": ["Not a valid integer."]}