Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate database parameters #14883

Merged
merged 1 commit into from May 27, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Apply validation for DB-specific parameters in the new DB flow.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Added a new test.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #14883 (4a4d41c) into master (281d637) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 4a4d41c differs from pull request most recent head 126b3b4. Consider uploading reports for the commit 126b3b4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14883      +/-   ##
==========================================
- Coverage   77.57%   77.46%   -0.12%     
==========================================
  Files         963      963              
  Lines       49290    49291       +1     
  Branches     6205     6205              
==========================================
- Hits        38235    38181      -54     
- Misses      10854    10909      +55     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql 81.59% <100.00%> (+<0.01%) ⬆️
postgres 81.62% <100.00%> (?)
presto 81.31% <100.00%> (+<0.01%) ⬆️
python 81.88% <100.00%> (-0.21%) ⬇️
sqlite 81.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/schemas.py 98.72% <100.00%> (+<0.01%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/connectors/sqla/models.py 89.52% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.91% <0.00%> (-0.13%) ⬇️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️
superset/views/base_api.py 98.28% <0.00%> (+0.42%) ⬆️
superset/db_engine_specs/postgres.py 96.96% <0.00%> (+1.01%) ⬆️
superset/sql_validators/postgres.py 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281d637...126b3b4. Read the comment docs.

@betodealmeida betodealmeida merged commit 8febd81 into apache:master May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants