Skip to content

Commit

Permalink
fix(explore): revert dnd column dependency array change to fix infini…
Browse files Browse the repository at this point in the history
…te rerenders (apache#16115)

* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment

(cherry picked from commit 772da8d)
  • Loading branch information
kgabryje authored and villebro committed Aug 10, 2021
1 parent 9e3a396 commit b8b9d51
Showing 1 changed file with 1 addition and 3 deletions.
Expand Up @@ -66,9 +66,7 @@ export const DndColumnSelect = (props: LabelProps) => {
) {
onChange(optionSelectorValues);
}
// when options change, that means that the dataset has changed
// so we have to check if values are still applicable.
}, [options, value, optionSelector]);
}, [JSON.stringify(value), JSON.stringify(optionSelector.getValues())]);

// useComponentDidUpdate to avoid running this for the first render, to avoid
// calling onChange when the initial value is not valid for the dataset
Expand Down

0 comments on commit b8b9d51

Please sign in to comment.